Use persistent workers for parLapply parallelism #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just copy over mc_process() from the mclapply stuff. Never thought such a hard problem would suddenly seem so easy!
We don't really need anything fancy there. I probably could have gotten away with never implementing migration from v4.4.0 caches to v5.0.0 caches.
Hopefully this removes the Travis pandoc error
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
========================================
+ Coverage 99.98% 100% +0.01%
========================================
Files 66 66
Lines 5474 5467 -7
========================================
- Hits 5473 5467 -6
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
...that will just be removed anyway when staged parallelism goes away.
Just set config$cluster to be your cluster and `drake` will use it.
Need to learn how to detect them first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
mc_process()inside ofparLapply()to makeparLapply()workers be persistent workers. Unit tests all pass locally under the"local_parLapply_2"testing scenario. No more staged parallelism formake(parallelism = "parLapply")!GitHub issues addressed
Checklist
drake's code of conduct, and I agree to follow its rules.testthatunit tests totests/testthatto confirm that any new features or functionality work correctly.devtools::check()