Persistent workers for future_lapply parallelism #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make more sense
It hangs currently. Needs work.
Use callr::r_bg for the master process there.
It hangs and I don't know why.
Best for future::plan(sequential), where only one worker runs at a time no matter what `jobs` is.
when verbose > 3
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 66 66
Lines 5485 5529 +44
=====================================
+ Hits 5485 5529 +44
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I did it!
make(parallelism = "future_lapply", jobs = n)launchesnpersistent workers that walk the dependency graph and build targets! Here, the master process is a specialcallr::r_bg()process.Another fix: workers have to clock in with
mc_set_ready()before the master process assigns them targets. That way,drakewill not hang if there are multiple "workers" but fewer processes that actually launch. For example,future_lapply()does not actually launch new processes forfuture::plan(sequential)To launch the 8 jobs promised above, use
future::plan(multicore)or any of the other non-serial backends.GitHub issues fixed
Checklist
drake's code of conduct, and I agree to follow its rules.testthatunit tests totests/testthatto confirm that any new features or functionality work correctly.devtools::check()