Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add future_lapply_staged parallelism #450

Merged
merged 3 commits into from
Jul 3, 2018
Merged

Conversation

wlandau
Copy link
Member

@wlandau wlandau commented Jul 3, 2018

Summary

make(parallelism = "future_lapply_staged") is a partial workaround for #448. It will also give us a chance to compare the efficiency of the "future" and "future_lapply" backends against their staged alternative.

Related GitHub issues

Checklist

  • I have read drake's code of conduct, and I agree to follow its rules.
  • I have read the guidelines for contributing.
  • I have listed any substantial changes in the development news.
  • I have added testthat unit tests to tests/testthat to confirm that any new features or functionality work correctly.
  • I have tested this pull request locally with devtools::check()
  • This pull request is ready for review.
  • I think this pull request is ready to merge.

@codecov-io
Copy link

codecov-io commented Jul 3, 2018

Codecov Report

Merging #450 into master will decrease coverage by 0.01%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage     100%   99.98%   -0.02%     
==========================================
  Files          66       66              
  Lines        5366     5390      +24     
==========================================
+ Hits         5366     5389      +23     
- Misses          0        1       +1
Impacted Files Coverage Δ
R/future.R 100% <100%> (ø) ⬆️
R/parallel_ui.R 100% <100%> (ø) ⬆️
R/distributed.R 100% <100%> (ø) ⬆️
R/staged.R 99.31% <95%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccca4d8...e6ce646. Read the comment docs.

@wlandau
Copy link
Member Author

wlandau commented Jul 3, 2018

@kendonB I think this make(parallelism = "future_lapply_staged") might work better for you for now. It even listens to future::plan(workers = n). Merging.

@wlandau wlandau merged commit adf5f87 into master Jul 3, 2018
@wlandau wlandau deleted the future_lapply_staged branch July 3, 2018 13:27
@kendonB
Copy link
Contributor

kendonB commented Jul 4, 2018

future_lapply_staged is working beautifully!

@wlandau
Copy link
Member Author

wlandau commented Jul 4, 2018

Glad to know! It's a keeper then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants