Add clustermq-based staged scheduling #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
- Coverage 99.98% 98.64% -1.34%
==========================================
Files 66 66
Lines 5390 5465 +75
==========================================
+ Hits 5389 5391 +2
- Misses 1 74 +73
Continue to review full report at Codecov.
|
This was referenced Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Despite the inefficiencies of staged scheduling, I do not want the perfect to be the enemy of the good. For now (until mschubert/clustermq#23 is solved) this PR's new
make(parallelism = "clustermq_staged")functionality is an attractive option in many use cases. Overhead is so much lower than in thefuture/batchtoolsbackends. In fact, jobs are so agile thatdrakeneeds to use checksums to wait for custom file targets to arrive over the network.cc @kendonB, @mschubert
Related GitHub issues
Checklist
drake's code of conduct, and I agree to follow its rules.testthatunit tests totests/testthatto confirm that any new features or functionality work correctly.devtools::check()