Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict scope of dependency detection #522

Merged
merged 14 commits into from
Sep 27, 2018
Merged

Restrict scope of dependency detection #522

merged 14 commits into from
Sep 27, 2018

Conversation

wlandau
Copy link
Member

@wlandau wlandau commented Sep 27, 2018

Summary

In build_drake_graph(), global dependencies are now restricted to objects in the environment and targets in the plan. The implementation relies on a new globals argument to code_dependencies(), which lists all the allowable globals.

Related GitHub issues and pull requests

Checklist

  • I have read drake's code of conduct, and I agree to follow its rules.
  • I have read the guidelines for contributing.
  • I have listed any substantial changes in the development news.
  • I have added testthat unit tests to tests/testthat to confirm that any new features or functionality work correctly.
  • I have tested this pull request locally with devtools::check()
  • This pull request is ready for review.
  • I think this pull request is ready to merge.

@codecov-io
Copy link

codecov-io commented Sep 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@41fba6b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #522   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     71           
  Lines             ?   6391           
  Branches          ?      0           
=======================================
  Hits              ?   6391           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
R/build_drake_graph.R 100% <100%> (ø)
R/envir.R 100% <100%> (ø)
R/dependencies.R 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41fba6b...c753d6e. Read the comment docs.

@wlandau wlandau changed the title 519 Restrict scope of dependency detection Sep 27, 2018
@wlandau wlandau merged commit 3cbbb2b into master Sep 27, 2018
@wlandau wlandau deleted the 519 branch September 27, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants