Fix #650 and #651 #652
Merged
Fix #650 and #651 #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the same plan
- config$graph: same, but with attributes for targets/imports - config$imports: a graph just for the imports - config$schedule: schedule for the targets - config$layout[[target]]$deps_build$memory: stuff to try to load into memory. Analogous slots for triggers. - Rely on `deps_graph()` for scheduling, but not for memory management.
Need to supply the target that came with the output file.
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 71 70 -1
Lines 5482 5453 -29
=====================================
- Hits 5482 5453 -29
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
config$graph: has everything in it, including output files.config$imports: a graph of just the imports. They do their own thing.config$schedule: a malleable schedule of targets. Excludes the imports, file outputs, etc. This is the graph we will try to modify while targets are building in DSL based on dplyr-like verbs? #233.All this could potentially increase speed, though I have not done any profiling yet.
Related GitHub issues and pull requests
Checklist
drake's code of conduct, and I agree to follow its rules.testthatunit tests totests/testthatto confirm that any new features or functionality work correctly.devtools::check()