allow classes inheriting from image display access to more state #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daizr
changed the title
dhood
reviewed
Dec 15, 2017
There was a problem hiding this comment.
Thanks for the patch @daizr, we're happy to consider your use case. However, we should only expose the minimum to subclasses, so we can't accept this proposal as is.
Would just moving texture_ and render_panel_ be sufficient? (these are what have been moved to protected for CameraDisplay in ddd7f35). If so, that would be an acceptable change.
|
replaced by https://github.com/ros-visualization/rviz/pull/1221/files exposing less state ( @daizr appears to have deleted their fork) |
130s
pushed a commit
to 130s/rviz
that referenced
this pull request
Aug 21, 2024
…ization#1162) Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 92023c966414d4d9a044ad8f609a1c6f3ca402d3) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed when adding roi selection overlay to image display here https://github.com/dispatch-ai/rviz-image-roi