Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change image push method and set tags correctly #287

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

ATarrio
Copy link
Collaborator

@ATarrio ATarrio commented Jul 4, 2024

  • Use the build-push action to actually push images instead of doing it with a shell command
  • Use the generated tags to push them to the registries
  • Remove step for setting version, we can just use github_ref_name.
  • Upgrade some actions versions to newer ones (like checkout which was giving a deprecation warning)

@ATarrio ATarrio requested a review from a team as a code owner July 4, 2024 19:23
@ATarrio ATarrio changed the title Fix Docker build workflow (warnings and image tags) Change image push method and set tags correctly Jul 4, 2024
@ATarrio ATarrio force-pushed the chalito/update_docker_workflow branch 3 times, most recently from 3a26c43 to f7f803d Compare July 11, 2024 12:45
@ATarrio ATarrio force-pushed the chalito/update_docker_workflow branch from b60b01e to 52098df Compare August 6, 2024 13:45
Copy link

sonarqubecloud bot commented Aug 6, 2024

Copy link

github-actions bot commented Feb 26, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/docker/build-push-action 6.*.* 🟢 5.4
Details
CheckScoreReason
Code-Review⚠️ 2Found 2/7 approved changesets -- score normalized to 2
Binary-Artifacts🟢 10no binaries found in the repo
Security-Policy🟢 9security policy file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Maintained🟢 1030 commit(s) and 12 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Branch-Protection🟢 5branch protection is not maximal on development and all release branches
Signed-Releases⚠️ -1no releases found
Packaging🟢 10packaging workflow detected
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Vulnerabilities🟢 55 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Manifest Files

.github/workflows/build-push-docker.yml
  • docker/build-push-action@6.*.*

@ATarrio ATarrio force-pushed the chalito/update_docker_workflow branch from addf3f5 to 45cea1b Compare February 26, 2025 22:01
@marcos-iov marcos-iov force-pushed the chalito/update_docker_workflow branch from 45cea1b to 36daec7 Compare February 27, 2025 13:42
@marcos-iov marcos-iov merged commit cdd39ea into master Feb 27, 2025
11 checks passed
@marcos-iov marcos-iov deleted the chalito/update_docker_workflow branch February 27, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants