Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added UI attestation module unit tests #109

Merged
merged 11 commits into from
Jan 9, 2023
Merged

Added UI attestation module unit tests #109

merged 11 commits into from
Jan 9, 2023

Conversation

italo-sampaio
Copy link
Collaborator

No description provided.

@italo-sampaio italo-sampaio self-assigned this Jan 3, 2023
@italo-sampaio italo-sampaio force-pushed the enhancement/97-add-unit-tests-for-ui-attestation-module branch from 9e2a668 to 80433f9 Compare January 3, 2023 14:38
amendelzon
amendelzon requested changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@amendelzon amendelzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far. I think there might be some issues with pointer usage, and also a need for additional testing of some scenarios.

@italo-sampaio italo-sampaio marked this pull request as draft January 5, 2023 20:09
@italo-sampaio
Improvements on buffer comparison on UI unit tests
0887240 
Make sure we don't treat binary data as strings for data comparison
@italo-sampaio
Reworked apdu_utils to use macros instead of functions
c6f8be7 
Helper macros now infer buffer size from sizeof() instead of receiving
data length as a parameter
@italo-sampaio
Added macro to assert that an array is filled with zeroes
68d89ed
@italo-sampaio
Added UI attestation module unit tests
1265f71
@italo-sampaio italo-sampaio force-pushed the enhancement/97-add-unit-tests-for-ui-attestation-module branch 2 times, most recently from efe2ca6 to 0708cd8 Compare January 6, 2023 20:47
@italo-sampaio
Fixed pointer usage
a0a529f
@italo-sampaio
Fixed magic numbers
86a0d9c
@italo-sampaio
Added verification of generated signature
7427d19
@italo-sampaio
Added test case for message paging
4285ba2 
- Corrected APDU buffer size
- Actually testing paging
@italo-sampaio
Changes after code review
eb160bf 
- Using new apdu helper macros instead of old set_apdu / assert_apdu
- Removed string comparison for binary data
- Fixed some test cases
- Removed magic numbers
@italo-sampaio italo-sampaio force-pushed the enhancement/97-add-unit-tests-for-ui-attestation-module branch from 0708cd8 to eb160bf Compare January 6, 2023 20:55
@italo-sampaio italo-sampaio marked this pull request as ready for review January 6, 2023 21:02
amendelzon
amendelzon requested changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@amendelzon amendelzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Minor things that we need to address and then we're ready to merge.

amendelzon
amendelzon approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@amendelzon amendelzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amendelzon amendelzon merged commit 7c74f9f into master Jan 9, 2023
@amendelzon amendelzon deleted the enhancement/97-add-unit-tests-for-ui-attestation-module branch January 9, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amendelzon amendelzon amendelzon approved these changes

Assignees

@italo-sampaio italo-sampaio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@italo-sampaio @amendelzon