Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit tests for UI signer authorization module #116

Merged
merged 12 commits into from
Jan 17, 2023
Merged

Added unit tests for UI signer authorization module #116

merged 12 commits into from
Jan 17, 2023

Conversation

italo-sampaio
Copy link
Collaborator

  • Added signer authorization unit tests
  • Added signer authorization unit tests to CI
  • Added NON_VOLATILE modifier to NVM variables
  • Moved runtime.h to common folder to allow usage in UI
  • Incidentally fixing log message on Makefile

amendelzon
amendelzon reviewed Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@amendelzon amendelzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a few comments of things we might want to look into.

@italo-sampaio
Minor fix on makefile log message
a20aa77
@italo-sampaio
Moved runtime.h to common
13c3767
@italo-sampaio
Added NON_VOLATILE modifier to NVM variables
292dc8e
@italo-sampaio
Added UI signer_authorization unit test
5c29062
@italo-sampaio
Added signer_authorization UI unit test to CI
2a88cfe
@italo-sampaio
Moved HSM_SIMULATOR define to specific tests
c2ec965 
HSM_SIMULATOR flag was defined at the top level mock library, now we're
moving the definition to the specific tests that need it
@italo-sampaio
Moved specific signer_authorization definitions to signer_authorizati…
3195616 
…on module

moved PARAM_INITIAL_SIGNER_HASH and PARAM_INITIAL_SIGNER_ITERATION to
signer_authorization
@italo-sampaio
Moved os_memmove definition to mock library
8d26aa4
@italo-sampaio
Using a different signer hash for test_op_sigaut_sigver
473991a
@italo-sampaio
Removed static from N_current_signer_status_var
610ed88 
Exposing N_current_signer_status_var allows us to directly assert its value in
the unit tests, and doesn't expose us to unecessary risk
@italo-sampaio italo-sampaio force-pushed the enhancement/102-add-unit-tests-for-ui-signer_authorization-module branch from 59a3e43 to 610ed88 Compare January 16, 2023 14:38
amendelzon
amendelzon previously approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@amendelzon amendelzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
One minor comment regarding the use of NON_VOLATILE in test-only NVM mock variables.

amendelzon
amendelzon previously approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@amendelzon amendelzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment

amendelzon
amendelzon approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@amendelzon amendelzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@italo-sampaio italo-sampaio merged commit c4de47d into master Jan 17, 2023
@italo-sampaio italo-sampaio deleted the enhancement/102-add-unit-tests-for-ui-signer_authorization-module branch January 17, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amendelzon amendelzon amendelzon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@italo-sampaio @amendelzon