Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip advanced block in NodeMessageHandler #505

Merged
merged 4 commits into from
Mar 14, 2018
Merged

Skip advanced block in NodeMessageHandler #505

merged 4 commits into from
Mar 14, 2018

Conversation

ajlopezrsk
Copy link
Contributor

To avoid invalid blocks by invalid uncles

@rskops
Copy link
Collaborator

rskops commented Mar 13, 2018

SonarQube analysis reported 6 issues

  1. MAJOR NodeBlockProcessor.java#L265: Method co.rsk.net.NodeBlockProcessor.processSkeletonRequest(MessageChannel, long, long) passes an incorrect number of parameters to an SLF4J logging statement rule
  2. MAJOR NodeBlockProcessor.java#L284: Method co.rsk.net.NodeBlockProcessor.processSkeletonRequest(MessageChannel, long, long) does not presize the allocation of a collection rule
  3. MAJOR NodeMessageHandler.java#L80: Constructor has 8 parameters, which is greater than 7 authorized. rule
  4. MAJOR NodeMessageHandler.java#L106: The Cyclomatic Complexity of this method "processMessage" is 18 which is greater than 10 authorized. rule
  5. MAJOR NodeMessageHandler.java#L335: Method co.rsk.net.NodeMessageHandler.relayBlock(MessageChannel, Block) appears to call the same method on the same object redundantly rule
  6. INFO NodeMessageHandler.java#L434: Complete the task associated to this TODO comment. rule

@aeidelman aeidelman merged commit 0624154 into master Mar 14, 2018
@aeidelman aeidelman deleted the advanced_block branch March 14, 2018 19:03
@aeidelman aeidelman added this to the Bamboo v0.4.1 milestone Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants