RFS-174 Performance improvement in getLowestBlock()

[pmprete]

Move call to getLowestBlock() to getBtcBlockchainBlockLocator() where its used to avoid calling it if its not mandatory

[colltoaction]

[rskops]

SonarQube analysis reported 65 issues

• 5 critical
• 36 major
• 8 minor
• 16 info

Top 10 issues

1. BridgeSupport.java#L335: Method co.rsk.peg.BridgeSupport.registerBtcTransaction(Transaction, byte[], int, byte[]) passes a concatenated string to SLF4J's format string
2. BridgeSupport.java#L343: Method co.rsk.peg.BridgeSupport.registerBtcTransaction(Transaction, byte[], int, byte[]) passes a concatenated string to SLF4J's format string
3. BridgeSupport.java#L356: Method co.rsk.peg.BridgeSupport.registerBtcTransaction(Transaction, byte[], int, byte[]) passes a concatenated string to SLF4J's format string
4. BridgeSupport.java#L372: Method co.rsk.peg.BridgeSupport.registerBtcTransaction(Transaction, byte[], int, byte[]) passes a concatenated string to SLF4J's format string
5. BridgeSupport.java#L847: Remove this unused method parameter "executionBlockNumber".
6. BridgeSupport.java#: This file has 1,184 lines, which is greater than 1,000 authorized. Split it into smaller files.
7. BridgeSupport.java#L213: Method co.rsk.peg.BridgeSupport.getCheckPoints() appears to call the same method on the same object redundantly
8. BridgeSupport.java#L308: The Cyclomatic Complexity of this method "registerBtcTransaction" is 16 which is greater than 10 authorized.
9. BridgeSupport.java#L429: Method co.rsk.peg.BridgeSupport.registerBtcTransaction(Transaction, byte[], int, byte[]) calls String.format on a static (non parameterized) format string
10. BridgeSupport.java#L429: Format-string method String.format(String, Object[]) called with format string "whitelist money return tx build for btc tx {} error. Return was to {}. Tx {}. Value {}" wants 0 arguments but is given 4 in co.rsk.peg.BridgeSupport.registerBtcTransaction(Transaction, byte[], int, byte[])