Added onBestBlock event #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diega
reviewed
Jun 6, 2018
| @@ -540,10 +540,13 @@ private void processBest(final Block block) { | |||
| EventDispatchThread.invokeLater(() -> transactionPool.processBest(block)); | |||
| } | |||
|
|
|||
| private void onBlock(Block block, BlockResult result) { | |||
| private void onBlock(Block block, BlockResult result, boolean isBest) { | |||
There was a problem hiding this comment.
Just to not repeat the same signature of the listeners, what if we call this method something like invokeListeners?
diega
approved these changes
Jun 7, 2018
|
SonarQube analysis reported 1 issue
|
josedahlquist
pushed a commit
that referenced
this pull request
Jun 14, 2018
* Added onBestBlock event * Changed flag for same checks in another method * Move inside the if the onBlock * Separate onBlock from onBestBlock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new type of event that only emits IMPORTED_BEST blocks instead of any block.