Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network id to peer discovery #601

Merged
merged 11 commits into from
Jun 23, 2018
Merged

Add network id to peer discovery #601

merged 11 commits into from
Jun 23, 2018

Conversation

adauto82
Copy link
Contributor

No description provided.

@adauto82 adauto82 force-pushed the add_network_id_to_peer_discovery branch from d843dd2 to f7094a4 Compare June 21, 2018 20:14
@rskops
Copy link
Collaborator

rskops commented Jun 22, 2018

SonarQube analysis reported 1 issue

  1. MINOR PeerExplorer.java#L76: Constructor has 8 parameters, which is greater than 7 authorized. rule

diega
diega approved these changes Jun 22, 2018
View reviewed changes
Copy link
Contributor

@diega diega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I would have preferred to have the parsing in co.rsk.net.discovery.message.PeerDiscoveryMessage given it's always at the end of every message in the hierarchy but the proposed implementation looks good enough 🙃. Good testing btw!

@ajlopezrsk ajlopezrsk merged commit 0044166 into master Jun 23, 2018
@aeidelman aeidelman added this to the Bamboo v0.4.4 milestone Jun 28, 2018
@bernacodesido bernacodesido deleted the add_network_id_to_peer_discovery branch September 5, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diega diega diega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Bamboo 0.4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@adauto82 @rskops @diega @aeidelman @ajlopezrsk