Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate compilation for each automaton #12

Closed
ghost opened this issue May 6, 2016 · 3 comments
Closed

Separate compilation for each automaton #12

ghost opened this issue May 6, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented May 6, 2016

They are all instantiated in ReactiveSocket.cpp right now, I believe.
@ghost ghost self-assigned this May 6, 2016
@ghost ghost mentioned this issue May 18, 2016
Merged
@lehecka
Copy link
Contributor

lehecka commented May 25, 2016

what is your motivating factor? compile time? Or do we plan on using them separately?

@ghost
Copy link
Author

ghost commented May 25, 2016

More like a general refactoring how we instantiate automata. That'd inline all of the mixins in one function and save a bunch of kB of code, I suppose.

While doing it, I can also take care of not instantiating all templates in the same CU, so -j we pass to make actually does something.

@yschimke
Copy link
Member

seems low enough priority we will never do this

@phoad phoad mentioned this issue Aug 24, 2017
Open
facebook-github-bot pushed a commit that referenced this issue Sep 26, 2020
@lukaspiatkowski @facebook-github-bot
mononoke/integration: build EdenSCM with non system OpenSSL (#12)
853208c 
Summary:
Pull Request resolved: facebookexperimental/rust-shed#12

The OpenSSL version on Mac doesn't work well with EdenSCM and Mononoke integration, just use the one from getdeps/brew.

Also remove the now redundant "DEVELOPER_DIR" since the modern XCode version works.

Pull Request resolved: facebook/sapling#63

Reviewed By: StanislavGlebik

Differential Revision: D23927022

Pulled By: lukaspiatkowski

fbshipit-source-id: 6b6b3baa33d49b567b9aa6178cbd20b7ae9edc89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yschimke @lehecka