Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iron out Rails/UniqBeforePluck #581

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

pirj
Copy link
Member

@pirj pirj commented Nov 10, 2021

Follow-up to #580 (comment)

Removed detection of distinct after pluck:

> User.pluck(:email).distinct
(1.3ms)  SELECT "users"."email" FROM "users"
NoMethodError: undefined method `distinct' for ["[email protected]"]:Array

Improved examples and reasoning text.

Unfold specs.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • [-] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • [-] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • [-] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Removed detection of `distinct` after `pluck`:
```ruby
> User.pluck(:email).distinct
(1.3ms)  SELECT "users"."email" FROM "users"
NoMethodError: undefined method `distinct' for ["[email protected]"]:Array
```

Improved examples and reasoning text.

Unfold specs.
@koic koic merged commit 497a2aa into rubocop:master Nov 11, 2021
@koic
Copy link
Member

koic commented Nov 11, 2021

Thanks! 👍

@pirj pirj deleted the improve-uniq_before_pluck-examples branch November 11, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants