Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #731] Fix an incorrect autocorrect for Rails/StripHeredoc #733

Merged

Conversation

kazarin
Copy link
Contributor

@kazarin kazarin commented Jun 27, 2022

Fixes #731

This PR fixes an incorrect autocorrect for Rails/StripHeredoc when squiggly already present


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic
Copy link
Member

koic commented Jun 27, 2022

Can you add a changelog entry and rebase with the latest master branch?

@koic
Copy link
Member

koic commented Jun 27, 2022

FYI, How to write a changelog is as follows.

@kazarin kazarin force-pushed the fix_incorrect_autocorrect_for_rails_strip_heredoc branch from be7a565 to 0bab24a Compare June 27, 2022 09:16
@kazarin kazarin force-pushed the fix_incorrect_autocorrect_for_rails_strip_heredoc branch from 0bab24a to c26b36c Compare June 27, 2022 09:19
@kazarin
Copy link
Contributor Author

kazarin commented Jun 27, 2022

Yep, added and rebased

@koic koic merged commit 0c18551 into rubocop:master Jun 28, 2022
@koic
Copy link
Member

koic commented Jun 28, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/StripHeredoc bad autocorrect when squiggly already present
2 participants