Skip to content

Commit

Permalink
Fix Azure acceptance test (#189)
Browse files Browse the repository at this point in the history
Added resource groups to the Azure subscription acceptance tests.
  • Loading branch information
johan3141592 authored Jul 26, 2024
1 parent 0e6e2c3 commit 1fc5d7d
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 6 deletions.
11 changes: 10 additions & 1 deletion internal/provider/provider_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,17 @@ type testAzureSubscription struct {
PrincipalName string `json:"principalName"`
PrincipalSecret string `json:"principalSecret"`

CloudNativeProtection struct {
Regions []string `json:"regions"`
ResourceGroupName string `json:"resourceGroupName"`
ResourceGroupRegion string `json:"resourceGroupRegion"`
} `json:"cloudNativeProtection"`

Exocompute struct {
SubnetID string `json:"subnetId"`
Regions []string `json:"regions"`
ResourceGroupName string `json:"resourceGroupName"`
ResourceGroupRegion string `json:"resourceGroupRegion"`
SubnetID string `json:"subnetId"`
} `json:"exocompute"`
}

Expand Down
14 changes: 12 additions & 2 deletions internal/provider/resource_azure_exocompute_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,18 @@ resource "polaris_azure_subscription" "default" {
tenant_domain = "{{ .Resource.TenantDomain }}"
cloud_native_protection {
resource_group_name = "{{ .Resource.CloudNativeProtection.ResourceGroupName }}"
resource_group_region = "{{ .Resource.CloudNativeProtection.ResourceGroupRegion }}"
regions = [
"eastus2",
]
}
exocompute {
resource_group_name = "{{ .Resource.Exocompute.ResourceGroupName }}"
resource_group_region = "{{ .Resource.Exocompute.ResourceGroupRegion }}"
regions = [
"eastus2",
]
Expand Down Expand Up @@ -86,12 +92,16 @@ func TestAccPolarisAzureExocompute_basic(t *testing.T) {
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "delete_snapshots_on_destroy", "false"),

// Cloud Native Protection feature
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.status", "connected"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.status", "CONNECTED"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.regions.#", "1"),
resource.TestCheckTypeSetElemAttr("polaris_azure_subscription.default", "cloud_native_protection.0.regions.*", "eastus2"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.resource_group_name",
subscription.CloudNativeProtection.ResourceGroupName),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.resource_group_region",
subscription.CloudNativeProtection.ResourceGroupRegion),

// Exocompute feature
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "exocompute.0.status", "connected"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "exocompute.0.status", "CONNECTED"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "exocompute.0.regions.#", "1"),
resource.TestCheckTypeSetElemAttr("polaris_azure_subscription.default", "exocompute.0.regions.*", "eastus2"),

Expand Down
24 changes: 21 additions & 3 deletions internal/provider/resource_azure_subscription_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ resource "polaris_azure_subscription" "default" {
tenant_domain = "{{ .Resource.TenantDomain }}"
cloud_native_protection {
resource_group_name = "{{ .Resource.CloudNativeProtection.ResourceGroupName }}"
resource_group_region = "{{ .Resource.CloudNativeProtection.ResourceGroupRegion }}"
regions = [
"eastus2",
]
Expand All @@ -67,6 +70,9 @@ resource "polaris_azure_subscription" "default" {
tenant_domain = "{{ .Resource.TenantDomain }}"
cloud_native_protection {
resource_group_name = "{{ .Resource.CloudNativeProtection.ResourceGroupName }}"
resource_group_region = "{{ .Resource.CloudNativeProtection.ResourceGroupRegion }}"
regions = [
"eastus2",
"westus2",
Expand Down Expand Up @@ -105,9 +111,13 @@ func TestAccPolarisAzureSubscription_basic(t *testing.T) {
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "delete_snapshots_on_destroy", "false"),

// Cloud Native Protection feature
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.status", "connected"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.status", "CONNECTED"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.regions.#", "1"),
resource.TestCheckTypeSetElemAttr("polaris_azure_subscription.default", "cloud_native_protection.0.regions.*", "eastus2"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.resource_group_name",
subscription.CloudNativeProtection.ResourceGroupName),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.resource_group_region",
subscription.CloudNativeProtection.ResourceGroupRegion),
),
}, {
Config: subscriptionTwoRegions,
Expand All @@ -119,10 +129,14 @@ func TestAccPolarisAzureSubscription_basic(t *testing.T) {
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "delete_snapshots_on_destroy", "false"),

// Cloud Native Protection feature
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.status", "connected"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.status", "CONNECTED"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.regions.#", "2"),
resource.TestCheckTypeSetElemAttr("polaris_azure_subscription.default", "cloud_native_protection.0.regions.*", "eastus2"),
resource.TestCheckTypeSetElemAttr("polaris_azure_subscription.default", "cloud_native_protection.0.regions.*", "westus2"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.resource_group_name",
subscription.CloudNativeProtection.ResourceGroupName),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.resource_group_region",
subscription.CloudNativeProtection.ResourceGroupRegion),
),
}, {
Config: subscriptionOneRegion,
Expand All @@ -134,9 +148,13 @@ func TestAccPolarisAzureSubscription_basic(t *testing.T) {
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "delete_snapshots_on_destroy", "false"),

// Cloud Native Protection feature
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.status", "connected"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.status", "CONNECTED"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.regions.#", "1"),
resource.TestCheckTypeSetElemAttr("polaris_azure_subscription.default", "cloud_native_protection.0.regions.*", "eastus2"),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.resource_group_name",
subscription.CloudNativeProtection.ResourceGroupName),
resource.TestCheckResourceAttr("polaris_azure_subscription.default", "cloud_native_protection.0.resource_group_region",
subscription.CloudNativeProtection.ResourceGroupRegion),
),
}},
})
Expand Down

0 comments on commit 1fc5d7d

Please sign in to comment.