Introduce override option for expose #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFnord
reviewed
Jan 29, 2018
| @@ -477,11 +477,20 @@ class Parent < Person | |||
| expect(child_class.represent({ name: 'bar' }, serializable: true)).to eq(email: nil, name: 'foo') | |||
| end | |||
|
|
|||
| it 'overrides parent class exposure' do | |||
| it 'not overrides exposure by default' do | |||
There was a problem hiding this comment.
did we have an example which overrides the exposure?
There was a problem hiding this comment.
Yep, I've used the spec I've written before https://github.com/ruby-grape/grape-entity/pull/297/files/0e86ebb5302ed9d2d4effc4d92eda7940abd13e1#diff-2f09e9dc67c5575f0172b3d0defe0e1bR489
LeFnord
approved these changes
Jan 29, 2018
|
Thanks for you work @DmitryTsepelev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion here #296. Please note that I've removed all other conditions, so even conditional or nesting exposure can be overwritten (should I throw an error or something when people configure their exposures in strange ways?)