Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly require set #55

Merged
merged 1 commit into from
Feb 1, 2014
Merged

explicitly require set #55

merged 1 commit into from
Feb 1, 2014

Conversation

aj0strow
Copy link
Contributor

@dblock
Copy link
Member

dblock commented Jan 31, 2014

Needs a CHANGELOG update, please under a Next Release.

@aj0strow
Copy link
Contributor Author

Ah sure. Nothing has changed though haha what do I write?

@dblock
Copy link
Member

dblock commented Jan 31, 2014

Well, it's a bug. If you don't explicitly require set you get an error. So I think it should say "Fix: undefined method `to_set'." and link to #54.

@aj0strow
Copy link
Contributor Author

Amended with changelog. Sorry again about the bug.

@dblock
Copy link
Member

dblock commented Feb 1, 2014

Perfect, thx.

dblock added a commit that referenced this pull request Feb 1, 2014
@dblock
Merge pull request #55 from aj0strow/to-set
a459dde 
explicitly require set
@dblock dblock merged commit a459dde into ruby-grape:master Feb 1, 2014
@aj0strow aj0strow deleted the to-set branch February 1, 2014 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.4.0 - undefined method `to_set'
2 participants
@aj0strow @dblock