Merge pull request #1706 from ksss/integer-pow

Fix Integer#pow signature
ruby · Jan 9, 2024 · 0391fe6 · 0391fe6
2 parents 56afe36 + ffaca43
commit 0391fe6
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 3 deletions.
diff --git a/core/integer.rbs b/core/integer.rbs
@@ -1028,9 +1028,10 @@ class Integer < Numeric
   #     a.pow(b)     #=> same as a**b
   #     a.pow(b, m)  #=> same as (a**b) % m, but avoids huge temporary values
   #
-  def pow: (Integer other, ?Integer modulo) -> Integer
-         | (Float) -> Float
-         | (Rational) -> Rational
+  def pow: (Integer other) -> (Integer | Rational)
+         | (Integer other, Integer modulo) -> Integer
+         | (Float) -> (Float | Complex)
+         | (Rational) -> (Float | Rational | Complex)
          | (Complex) -> Complex
 
   # <!--

diff --git a/test/stdlib/Integer_test.rb b/test/stdlib/Integer_test.rb
@@ -369,3 +369,30 @@ def test_try_convert
     )
   end
 end
+
+class IntegerInstanceTest < Test::Unit::TestCase
+  include TestHelper
+
+  testing "::Integer"
+
+  def test_pow
+    assert_send_type "(Integer) -> Integer",
+                     1, :pow, 2
+    assert_send_type "(Integer) -> Rational",
+                     -2, :pow, -1
+    assert_send_type "(Integer, Integer) -> Integer",
+                     1, :pow, 2, 10
+    assert_send_type "(Float) -> Float",
+                     1, :pow, 1.0
+    assert_send_type "(Float) -> Complex",
+                     -9, :pow, 0.1
+    assert_send_type "(Rational) -> Float",
+                     2, :pow, 1/2r
+    assert_send_type "(Rational) -> Rational",
+                     1, :pow, 1r
+    assert_send_type "(Rational) -> Complex",
+                     -3, :pow, -4/3r
+    assert_send_type "(Complex) -> Complex",
+                     1, :pow, 1i
+  end
+end