Fix symbol and string literal types' `to_s` #1316

pocke · 2023-04-24T09:01:32Z

No description provided.

sampersand · 2023-09-04T03:02:26Z

lib/rbs/types.rb

+
+      def string_to_s(str)
+        content = str.chars.map do |c|
+          case c


Wouldnt a hash and [] work better? like str.chars.map { |c| SPECIAL_CHARS.fetch(c, c) } ?

pocke force-pushed the Fix_symbol_and_string_literal_types___to_s_ branch from a089c4f to 5ae16b3 Compare April 24, 2023 09:12

Fix symbol and string literal types' to_s

ce04970

pocke force-pushed the Fix_symbol_and_string_literal_types___to_s_ branch from 5ae16b3 to ce04970 Compare June 8, 2023 02:18

This was referenced Jun 8, 2023

rbs prototype rb generates wrong definitions for files including "#$" #1348

Open

Parsing errors occur in null-byte character type definitions #1344

Closed

sampersand reviewed Sep 4, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix symbol and string literal types' `to_s` #1316

Fix symbol and string literal types' `to_s` #1316

pocke commented Apr 24, 2023

sampersand Sep 4, 2023

Fix symbol and string literal types' to_s #1316

Are you sure you want to change the base?

Fix symbol and string literal types' to_s #1316

Conversation

pocke commented Apr 24, 2023

sampersand Sep 4, 2023

Choose a reason for hiding this comment

Fix symbol and string literal types' `to_s` #1316

Fix symbol and string literal types' `to_s` #1316