Optimize URI#hostname and URI#hostname=

ruby · Oct 7, 2020 · 36c3fd7 · 36c3fd7
1 parent 88eeea8
commit 36c3fd7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/uri/generic.rb b/lib/uri/generic.rb
@@ -643,7 +643,7 @@ def host=(v)
     #
     def hostname
       v = self.host
-      /\A\[(.*)\]\z/ =~ v ? $1 : v
+      v&.start_with?('[') && v.end_with?(']') ? v[1..-2] : v
     end
 
     # Sets the host part of the URI as the argument with brackets for IPv6 addresses.
@@ -659,7 +659,7 @@ def hostname
     # it is wrapped with brackets.
     #
     def hostname=(v)
-      v = "[#{v}]" if /\A\[.*\]\z/ !~ v && /:/ =~ v
+      v = "[#{v}]" if !(v&.start_with?('[') && v&.end_with?(']')) && v&.index(':')
       self.host = v
     end