chore: logger with config (#717)

rudderlabs · Jan 15, 2025 · d5c4932 · d5c4932
1 parent d59a83f
commit d5c4932
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/maxprocs/maxprocs.go b/maxprocs/maxprocs.go
@@ -20,9 +20,9 @@ func init() {
 }
 
 func setDefault() {
-	SetWithConfig(config.New(config.WithEnvPrefix("MAXPROCS")),
-		WithLogger(logger.NewLogger().Child("maxprocs")),
-	)
+	c := config.New(config.WithEnvPrefix("MAXPROCS"))
+	l := logger.NewFactory(c).NewLogger().Child("maxprocs")
+	SetWithConfig(c, WithLogger(l))
 }
 
 type conf struct {

diff --git a/maxprocs/maxprocs_test.go b/maxprocs/maxprocs_test.go
@@ -212,6 +212,7 @@ func TestEnvironmentVariables(t *testing.T) {
 	before := runtime.GOMAXPROCS(0)
 	defer runtime.GOMAXPROCS(before)
 
+	t.Setenv("MAXPROCS_LOGGER_CONSOLE_JSON_FORMAT", "true")
 	t.Setenv("MAXPROCS_REQUESTS", "1100m")
 
 	setDefault()