Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Hyperformula #655

Merged
merged 6 commits into from
Jan 18, 2025
Merged

Conversation

Corbe30
Copy link
Contributor

@Corbe30 Corbe30 commented Dec 23, 2024

  • Replace formula-parser with Hyperformula

Fixes:

Performance:

  • ~50% improvement in edit operations on large sheets (850ms -> 440ms)

@Corbe30 Corbe30 changed the title (do not merge) Feature: Hyperformula Feature: Hyperformula Dec 24, 2024
@Corbe30
Copy link
Contributor Author

Corbe30 commented Dec 24, 2024

Existing unreported bugs resolved:

  • incorrect patches sent in add/delete sheet
  • insert/delete row/col redo had incorrect formula cached

Optimized:

  • formulaHelper.ts:246 - removed cloneDeep by refreshing formulaObject.color

@sanchit3008
Copy link
Collaborator

i tried a lot of diff combinations, some of them break the sheet such as =IFERROR(A1 "abcd") produces this error. we will need to be caerful with a change of this magnitude

image

@Corbe30
Copy link
Contributor Author

Corbe30 commented Jan 3, 2025

@sanchit3008 fixed! thoroughly tested this time. Please review again ✨

Copy link
Collaborator

@sanchit3008 sanchit3008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have reviewed this and we can go ahead with a major release

@sanchit3008 sanchit3008 merged commit 4bf48b5 into ruilisi:master Jan 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants