pnp4nagios update for php5.6 to php8.0 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
September 11, 2022 13:02
other files to make rpm building work better
avoid fontconfig crashes.
note that pid files moved from /var/run to /run, in line with modern linux
remove rrd_convert and rrd_modify, because they do not work for current rrd xml configuration.
file locking is needed for the few times/day when a pair of process_perfdata runs try to update the stats file at the same time; minor but annoying. Updated release version in .spec file
add logwatch config setup spec file update
russellvt
requested changes
May 9, 2023
There was a problem hiding this comment.
This should be broken apart intop smaller changes (Read: It's not just "PHP5-PHP8" migration).
Some ideas for general categories:
- Fix RPM Build from
git - Various Fedora contribs:
** Logwatch forpnp4nagios
**npcdsystem/service/startup configurations and scripts
** Logrotate configuration - Fixes
rpmbuildfromgit - File locking for process_perfdata
** Is this actually needed? Is there a race/contention there, right now, between threads?
Note: This also appears to break / change some things / nehaviour in potentially unexpected ways on other platforms. Some examples:
- Should likely remove Subversion tags sich as
$Id$(in-comments, essentially harmless) - Removes previously used environment variables and adds others
- Hard-coded non-standard (?) directories (eg. /run instead of /var/run)
Overall, I appreciate the contirbution!
It would be nice to break this apart into smaller bite-size quantites, though (all of the Fedora contrib, for example). Most of this isn't a "PHP8 migration," unfortunately.
so have to do it explicitly. Also, set up environment variable XDG_CACHE_HOME in systemd startup of httpd with a plugin
php8.1+ usual complaints about auto-creating arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes: update for php8.0
packaging (make rpms easier ... see spec file in dist and README)
file lock in process_perfdata.pl to avoid some errors.
rrdtools needs env setting XDG_CACHE_HOME for fontconfig
Tested on Fedora 35 (php 8.0) Alma 8.6 (php 7.2) and Fedora 22 (php 5.6).