Restructure and slightly refactor code #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See rust-lang/rust-clippy#9271, this is a bug in clippy
shssoichiro
requested changes
Nov 25, 2022
| @@ -1,3 +1,7 @@ | |||
| #![allow(clippy::cast_possible_wrap)] | |||
| #![allow(clippy::cast_precision_loss)] | |||
| #![allow(clippy::cast_sign_loss)] | |||
There was a problem hiding this comment.
Why do these need to be added?
There was a problem hiding this comment.
powf has some code that causes clippy warnings. For example x.to_bits() as i32 can wrap. If you want, i can go further into it, but IMO the warnings indicate problems that either can't happen with our assumptions or don't matter (wrapping doesn't matter because we're just using the value for bitwise operations).
shssoichiro
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried "cleaning up" a bit. Mostly by moving code out of
lib.rs. It's now just the tests and some re-exporting from the new modules.List of changes:
FullTypeName->Selfwhere applicable)rustfmtinto_data()function that "consumes" self to return the dataVec<[f32; 3]>. This is A) needed to implement the conversion functions withoutpub(crate)and B) can also be used by API users, which is a neat solution IMHOAltogether, this changes the internal structure a bit but doesn't really touch the public API. You can technically access things like
yuvxyb::rgb_xyb::linear_rgb_to_xybat the moment (which would be impossible after this change), but I'd consider those functions to be internal so this is only a "kind of breaking" change IMO.