Add Parser
implementation for nom::combinator::value
#1829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salut Geoffroy!
This PR adds a
Parser
implementation fornom::combinator::value
, so that the underlying parser is always run inCheck
mode and the parser value is never emitted, as it would be replaced by the user-provided value anyway.The old code is doing:
which basically delegates to using the
Parser::map
implementation.Parser::map
maps the closure to the output of the parser, which means that the parser output must always be emitted. But since in the case ofvalue
we are gonna ignore the result anyway, we can actually always run the underlying parser inCheck
mode.I added a dedicated
Value<F, O1>
struct with he following implementation to avoid emitting the inner parser value (similarly topreceded
, etc.):I don't think the
value
combinator is tested anywhere outside of the doctests, let me know if I should add some tests as well.