fix: Allow empty tags in BAM header #384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I recently ran into an issue where BAM files with empty tags in their header fail with rust-htslib whereas they work fine with samtools and even with
quickcheck
within samtools. For example a barcode tag without a value (BC:
) within@RG
would throw an unwrap error when usingto_hashmap
.This just needs a one character change in the regex
+
->*
, so hopefully wont cause any issues or changes in compatibility.Thanks for considering!
Mitchell