Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow empty tags in BAM header #384

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

mrvollger
Copy link
Contributor

Hello,

I recently ran into an issue where BAM files with empty tags in their header fail with rust-htslib whereas they work fine with samtools and even with quickcheck within samtools. For example a barcode tag without a value (BC:) within @RG would throw an unwrap error when using to_hashmap.

This just needs a one character change in the regex + -> *, so hopefully wont cause any issues or changes in compatibility.

Thanks for considering!
Mitchell

Allow for empty tags in the bam header.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4661386895

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.962%

Totals Coverage Status
Change from base Build 4562489535: 0.0%
Covered Lines: 2267
Relevant Lines: 2871

💛 - Coveralls

@johanneskoester johanneskoester merged commit 7d4990b into rust-bio:master Apr 14, 2023
@johanneskoester
Copy link
Contributor

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants