Linux & BSD support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eduardo Flores <[email protected]>
Co-authored-by: Eduardo Flores <[email protected]>
Co-authored-by: Eduardo Flores <[email protected]>
First, try XDG Desktop Portal dbus API (compatible with Flatpak sandboxing). If that does not work, fall back to checking if the theme name contains the string "dark". Checking the theme name is supported on: - Cinnamon - GNOME - KDE - MATE - Unity - XFCE Co-authored-by: Eduardo Flores <[email protected]> Co-authored-by: Corey Farwell <[email protected]>
|
Unfortunately it seems the KDE method is not really working. I suggest we change to the same method as KDE's implementation of the XDG Desktop Portal by reading the |
Closed
|
Alright, I'll get on that next 👍 |
|
Maybe serde_ini could help? I'm not sure. |
|
The calculation of the grayscale value with qGray is simply |
Added `rgb` method to Mode to implement qGray.
|
Done, could you test it before we merge @Be-ing? |
Be-ing
commented
Jan 15, 2022
|
I just enabled GitHub Actions for CI. Mentioning in case you want to merge/rebase to pick that up here |
It now checks `BackgroundNormal` under `Colors:Window`.
|
I have no preference between rebasing/merging/squashing. Do whatever you'd like! |
frewsxcv
reviewed
Jan 17, 2022
|
Closes #1 |
|
I tested this on KDE Plasma 5.23.4 on Fedora 34 switching between several color schemes and it works! Great job! |
|
By the way, I've been improving the code, looks way better. I'll try to upload the commit tonight so you can review it in the morning. unless you're a night owl 🦉 |
|
@frewsxcv shall we make a new release now that this is merged? |
|
How about we wait until we have #10 ready? |
|
#10 may take some time to polish and implement on all platforms. I don't think we need to hold back a release for that. Version numbers are cheap. :) |
|
Alright then! 👍🏼 |
|
0.2.0 released! |
Be-ing
added a commit
to Be-ing/rust-dark-light
that referenced
this pull request
Oct 7, 2024
and remove unused code. Before, the sync and async APIs had completely separate implementations. When Linux support was first added in rust-dark-light#6 the XDG Desktop Portal color-scheme API was new and not yet widely supported, so fallbacks were needed. Now, the portal API is more widely supported so the fallbacks are not needed. In my testing, the portal works on: KDE Plasma GNOME Cinnamon Xfce MATE does not currently support the portal API. Selecting MATE's GTK themes from Xfce's settings also does not change what xdg-desktop-portal-gtk reports. I am not sure, but I think that may be due to missing metadata in MATE's GTK themes. The old implementation never worked on MATE anyway because MATE's dark themes don't have "dark" in their name, so there's no regression removing it.
Be-ing
added a commit
to Be-ing/rust-dark-light
that referenced
this pull request
Oct 7, 2024
Before, the sync and async APIs had completely separate implementations. When Linux support was first added in rust-dark-light#6 the XDG Desktop Portal color-scheme API was new and not yet widely supported, so fallbacks were needed. Now, the portal API is more widely supported so the fallbacks are not needed. In my testing, the portal works on: KDE Plasma GNOME Cinnamon Xfce MATE does not currently support the portal API. Selecting MATE's GTK themes from Xfce's settings also does not change what xdg-desktop-portal-gtk reports. I am not sure, but I think that may be due to missing metadata in MATE's GTK themes. The old implementation never worked on MATE anyway because MATE's dark themes don't have "dark" in their name, so there's no regression removing it.
Be-ing
added a commit
to Be-ing/rust-dark-light
that referenced
this pull request
Oct 7, 2024
Before, the sync and async APIs had completely separate implementations. When Linux support was first added in rust-dark-light#6 the XDG Desktop Portal color-scheme API was new and not yet widely supported, so fallbacks were needed. Now, the portal API is more widely supported so the fallbacks are not needed. In my testing, the portal works on: KDE Plasma GNOME Cinnamon Xfce MATE does not currently support the portal API. Selecting MATE's GTK themes from Xfce's settings also does not change what xdg-desktop-portal-gtk reports. I am not sure, but I think that may be due to missing metadata in MATE's GTK themes. The old implementation never worked on MATE anyway because MATE's dark themes don't have "dark" in their name, so there's no regression removing it.
Be-ing
added a commit
to Be-ing/rust-dark-light
that referenced
this pull request
Oct 8, 2024
Before, the sync and async APIs had completely separate implementations. When Linux support was first added in rust-dark-light#6 the XDG Desktop Portal color-scheme API was new and not yet widely supported, so fallbacks were needed. Now, the portal API is more widely supported so the fallbacks are not needed. In my testing, the portal works on: KDE Plasma GNOME Cinnamon Xfce MATE does not currently support the portal API. Selecting MATE's GTK themes from Xfce's settings also does not change what xdg-desktop-portal-gtk reports. I am not sure, but I think that may be due to missing metadata in MATE's GTK themes. The old implementation never worked on MATE anyway because MATE's dark themes don't have "dark" in their name, so there's no regression removing it.
Be-ing
added a commit
that referenced
this pull request
Oct 8, 2024
Before, the sync and async APIs had completely separate implementations. When Linux support was first added in #6 the XDG Desktop Portal color-scheme API was new and not yet widely supported, so fallbacks were needed. Now, the portal API is more widely supported so the fallbacks are not needed. In my testing, the portal works on: KDE Plasma GNOME Cinnamon Xfce MATE does not currently support the portal API. Selecting MATE's GTK themes from Xfce's settings also does not change what xdg-desktop-portal-gtk reports. I am not sure, but I think that may be due to missing metadata in MATE's GTK themes. The old implementation never worked on MATE anyway because MATE's dark themes don't have "dark" in their name, so there's no regression removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #4 squashed and with a few small commits split out, plus updating README.md, formatting changes, and fixing a few clippy warnings.