Ensure that returned static slices in dart don't get deallocated #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
dart-static-ownership
branch
from
df75194 to
ea5ae79
Compare
robertbastian
changed the title
robertbastian
approved these changes
Feb 24, 2025
Manishearth
force-pushed
the
dart-static-ownership
branch
from
ea5ae79 to
b28b9d8
Compare
|
I'm not going to update this in ICU4X since this will have to be updated pre-release anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #796
JS does not need this fix, JS does not appear to support returning owned slices (#786).