Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include rustc overflowing its stack as an ICE #142

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Include rustc overflowing its stack as an ICE #142

merged 1 commit into from
Feb 25, 2022

Conversation

Alexendoo
Copy link
Member

Helpful for when you're bisecting something that overflows before emitting an ICE diagnostic

ehuss
ehuss approved these changes Feb 25, 2022
View reviewed changes
Copy link
Collaborator

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit on the fence, as I don't usually equate an overflow with ICE. But since they are pretty similar, and I doubt anyone needs to check them independently, I'm going to go ahead and merge. Thanks!

@ehuss ehuss merged commit 5298e9d into rust-lang:master Feb 25, 2022
@Alexendoo Alexendoo deleted the stack-overflow branch February 25, 2022 18:20
@ehuss ehuss mentioned this pull request Mar 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexendoo @ehuss