Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on previous versions of rust #365

Merged
merged 3 commits into from
Dec 21, 2018

Conversation

TheBlueMatt
Copy link
Contributor

@TheBlueMatt TheBlueMatt commented Dec 19, 2018

Switching to a function due to deprecation when it isn't even deprecated yet, let alone removed, seems significantly premature, and breaks lots of downstream users.

Addresses the non-meta part of #364.

@alexcrichton
Copy link
Member

Switching to a function due to deprecation when it isn't even deprecated yet

This is not true, the deprecation is riding the trains from nightly to stable. The rust standard library never removes stable functions, and users always have the option of sticking with the old functions if desired.

seems significantly premature

This crate's policy on version requirements is the current and prior stable, which makes a window of at least 6 weeks if not more for including new features.

breaks lots of downstream users

I'm sorry for the breakage, it's never fun! I would recommend a Cargo.lock file to prevent unwanted upgrades, as this crate is not the only one which has the same version policy.

@TheBlueMatt
Copy link
Contributor Author

TheBlueMatt commented Dec 19, 2018

See my #364 (comment) comment on the associated issue, but, indeed, I'd missed that deny(warnings) was preventing compilation on nightly/CI instead of just generating a warning as I expected. In any case, I laid out the reasons why such breakage is not resolved with cargo vendor there. Sadly the https://github.com/rust-bitcoin/ projects are slowly being forced to cut out every dependency that isn't another project maintained by the same people to maintain stability and satisfy customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants