Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make futures::task::noop_waker_ref available without std. #2505

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Make futures::task::noop_waker_ref available without std. #2505

merged 1 commit into from
Oct 8, 2021
+0 −1

Conversation

kpreid
Copy link
Contributor

@kpreid kpreid commented Oct 8, 2021

#2332 removed the std dependency and some #[cfg(feature = "std")], but missed the one on the reexport from futures_util. This PR removes that cfg attribute, so noop_waker_ref should be equally available from all places it is reexported. I searched for other mentions of noop_waker_ref in this repository and did not find any other changes needed.

@kpreid
Make futures::task::noop_waker_ref available without std.
5390d1a 
Commit 232ed5f removed the std
dependency, and 4c09f82 made it
exported unconditionally from `futures_task`, but the `cfg` on the
reexport from `futures_util` (and hence indirectly `futures`) was left
in place until now.
@kpreid kpreid requested a review from taiki-e as a code owner October 8, 2021 15:45
taiki-e
taiki-e approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e added 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. A-task Area: futures::task labels Oct 8, 2021
@taiki-e taiki-e merged commit ee23679 into rust-lang:master Oct 8, 2021
taiki-e pushed a commit that referenced this pull request Nov 23, 2021
@kpreid @taiki-e
Make futures::task::noop_waker_ref available without std. (#2505)
44e1684 
Commit 232ed5f removed the std
dependency, and 4c09f82 made it
exported unconditionally from `futures_task`, but the `cfg` on the
reexport from `futures_util` (and hence indirectly `futures`) was left
in place until now.
@taiki-e taiki-e mentioned this pull request Nov 23, 2021
Merged
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Nov 23, 2021
taiki-e pushed a commit that referenced this pull request Nov 23, 2021
@kpreid @taiki-e
Make futures::task::noop_waker_ref available without std. (#2505)
f44ffdc 
Commit 232ed5f removed the std
dependency, and 4c09f82 made it
exported unconditionally from `futures_task`, but the `cfg` on the
reexport from `futures_util` (and hence indirectly `futures`) was left
in place until now.
taiki-e pushed a commit that referenced this pull request Nov 23, 2021
@kpreid @taiki-e
Make futures::task::noop_waker_ref available without std. (#2505)
c4bd5ce 
Commit 232ed5f removed the std
dependency, and 4c09f82 made it
exported unconditionally from `futures_task`, but the `cfg` on the
reexport from `futures_util` (and hence indirectly `futures`) was left
in place until now.
@taiki-e taiki-e mentioned this pull request Nov 23, 2021
Merged
@taiki-e
Copy link
Member

taiki-e commented Nov 23, 2021

Published in 0.3.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
0.3-backport: completed A-task Area: futures::task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpreid @taiki-e