-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base definitions for riscv64 + musl #2537
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
@bors r+ |
📌 Commit ec848bc has been approved by |
Add base definitions for riscv64 + musl This is picking up the stale MR that was closed for inactivity: #1994
💔 Test failed - checks-actions |
Seems like the failure is not related to the MR? |
It's allow-to-fail, the actual failure is https://github.com/rust-lang/libc/runs/4220070674?check_suite_focus=true |
I believe that is now a valid rust target, so not sure how to address the failure? |
There is no pre-build std in rustup for this target. You need to add it to |
Done. |
@bors r+ |
📌 Commit 8d68878 has been approved by |
Add base definitions for riscv64 + musl This is picking up the stale MR that was closed for inactivity: #1994
💔 Test failed - checks-actions |
I guess all of the following definitions should be dropped?
|
I'm... not exactly sure why this is failing on macos... |
Yes, seems completely unrelated. I'll trigger a CI once more. |
Signed-off-by: Alexander Kanavin <[email protected]>
Signed-off-by: Alexander Kanavin <[email protected]>
Maybe the failure was because the commits weren't rebased on latest master. |
@bors r+ |
📌 Commit f699c8f has been approved by |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
This is picking up the stale MR that was closed for inactivity:
#1994