Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to matching target_os rather than target_vendor #4282

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

tgross35
Copy link
Contributor

ctest is very particular about this and the current configuration, though working most of the time, seems to cause occasional CI errors that can't easily be explained or mitigated. Switch back to matching all Apple target_os options until ctest is fixed.

`ctest` is very particular about this and the current configuration,
though working most of the time, seems to cause occasional CI errors
that can't easily be explained or mitigated. Switch back to matching all
Apple `target_os` options until `ctest` is fixed.
@rustbot
Copy link
Collaborator

rustbot commented Feb 22, 2025

@tgross35: no appropriate reviewer found, use r? to override

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Feb 22, 2025
@tgross35 tgross35 enabled auto-merge February 22, 2025 22:26
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Feb 22, 2025
`ctest` is very particular about this and the current configuration,
though working most of the time, seems to cause occasional CI errors
that can't easily be explained or mitigated. Switch back to matching all
Apple `target_os` options until `ctest` is fixed.

(backport <rust-lang#4282>)
(cherry picked from commit a986f81)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Feb 22, 2025
`ctest` is very particular about this and the current configuration,
though working most of the time, seems to cause occasional CI errors
that can't easily be explained or mitigated. Switch back to matching all
Apple `target_os` options until `ctest` is fixed.

(backport <rust-lang#4282>)
(cherry picked from commit a986f81)
@tgross35 tgross35 added this pull request to the merge queue Feb 22, 2025
Merged via the queue into rust-lang:main with commit 60b269f Feb 22, 2025
44 checks passed
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Feb 22, 2025
`ctest` is very particular about this and the current configuration,
though working most of the time, seems to cause occasional CI errors
that can't easily be explained or mitigated. Switch back to matching all
Apple `target_os` options until `ctest` is fixed.

(backport <rust-lang#4282>)
(cherry picked from commit a986f81)
@tgross35 tgross35 mentioned this pull request Feb 22, 2025
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Feb 22, 2025
`ctest` is very particular about this and the current configuration,
though working most of the time, seems to cause occasional CI errors
that can't easily be explained or mitigated. Switch back to matching all
Apple `target_os` options until `ctest` is fixed.

(backport <rust-lang#4282>)
(cherry picked from commit a986f81)
@tgross35 tgross35 deleted the target-vendor branch February 22, 2025 23:35
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants