-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cr_log from core-math #326
base: master
Are you sure you want to change the base?
Conversation
Initial pass with things looking correct shows a 15x regression for softfloat mode
|
Overflow Formatting Fix dint arithmetic fix another case fix another case, quick tests passing clippy cleanup more tests passing
Version with fma is much more tolerable
|
Hm, the LUTs here have a huge impact on binary size. Thinking maybe I should keep the current implementations around behind a feature gate. Edit: or maybe just have an option to only use the fast method without |
I should try marking the accurate versions |
I think the ideal API surface would be the
That does seem more maintainable than having two completely separate implementations. |
Don't look too close, this is intentionally terrible code (line for line)
ci: allow-regressions