Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'is_empty' method for 'std::path::Path' #1497

Closed
frewsxcv opened this issue Feb 12, 2016 · 6 comments
Closed

Add 'is_empty' method for 'std::path::Path' #1497

frewsxcv opened this issue Feb 12, 2016 · 6 comments
Labels
T-libs-api Relevant to the library API team, which will review and decide on the RFC.

Comments

@frewsxcv
Copy link
Member

Related to rust-lang/rust#31231
@frewsxcv frewsxcv mentioned this issue Feb 12, 2016
Closed
@tshepang
Copy link
Member

But this was done on that linked PR?

@untitaker
Copy link
Contributor

Proper rationale here: rust-lang/rust#30259

IMO it doesn't really make any semantical sense for a path to be empty, and adding is_empty breaks the abstraction.

@ticki
Copy link
Contributor

ticki commented Feb 20, 2016

Is this really worth an RFC? I mean this is an incredibly small issue, and doubt anyone would be against it.

@frewsxcv
Copy link
Member Author

@alexcrichton Should I/we bother with the RFC dance here or can I/we assume that rust-lang/rust#31231 (comment) is confirmation of acceptance about Path::is_empty

@alexcrichton
Copy link
Member

Yeah this is probably fine without an RFC (it'll start out as unstable anyway)

@frewsxcv
Copy link
Member Author

Cool, I'll open a PR for this in rust-lang/rust then.

@frewsxcv frewsxcv mentioned this issue Feb 25, 2016
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 25, 2016
@frewsxcv
Add std::path::Path::is_empty.
82163fe 
Original issue requesting this feature:
rust-lang#30259

Originally implemented in rust-lang#30623
but that pull request when stale.

It was rebased in rust-lang#31231, but the
`Path` changes got lost as the focus shifted towards `OsString` and
`OsStr`.

An RFC (rust-lang/rfcs#1497) was briefly
opened, since I didn't know if this functionality needed an RFC, but
@alexcrichton clarified in the RFC issue I linked that this is not the
case.
@Centril Centril added the T-libs-api Relevant to the library API team, which will review and decide on the RFC. label Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-libs-api Relevant to the library API team, which will review and decide on the RFC.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@alexcrichton @frewsxcv @tshepang @untitaker @Centril @ticki