Add diagram back to RFC 3606. #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-ou-se
added
the
not-rfc
m-ou-se
referenced
this pull request
May 14, 2024
The FCP has completed on RFC 3606, so let's prepare it to be merged. First, we'll shorten the name of the feature flag a bit; this should still be unambiguous. Second, we're going to remove the graphic from the summary. While it may be illustrative, the text and the other examples seem clear enough without it, and its benefits have to be weighed against the fact that we want the content in this repository to be easily editable and freestanding. Pulling in an SVG file from an outside host pulls against that. If we come to think the graphic is critical, we could always add it back in a separate PR that would add an editable version of this SVG file into the repository itself. Third, let's make the H1 title of the document a bit more clear.
|
cc @traviscross |
|
wouldn't it be better to put the diagram directly in this repository similar to the SVG for #2856 |
Moved it into the repository. Not sure if that works on github's previews, but it should work on the rfcs website/book/thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diagram was silently removed in 929c584, but it's an important part of the summary. This puts the diagram back. (This time hosted on github.)
Rendered