Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup automatic publishing of libs crates #13912

Closed
Veykril opened this issue Jan 9, 2023 · 7 comments
Closed

Fixup automatic publishing of libs crates #13912

Veykril opened this issue Jan 9, 2023 · 7 comments
Labels
A-infra CI and workflow issues C-feature Category: feature request

Comments

@Veykril
Copy link
Member

Veykril commented Jan 9, 2023

Since the rust-lang move, we no longer automatically publish these once we bump their version. We should look into making that work again.

@Veykril Veykril added C-feature Category: feature request A-infra CI and workflow issues labels Jan 9, 2023
@jonas-schievink jonas-schievink self-assigned this Jan 25, 2023
bors added a commit that referenced this issue Jan 25, 2023
…evink

internal: Try to fix auto-publishing of lib crates

#13912
@jonas-schievink jonas-schievink removed their assignment Jan 30, 2023
@pksunkara
Copy link
Contributor

I can look into getting this working again. What exactly happened?

@Veykril
Copy link
Member Author

Veykril commented Feb 11, 2023

Auto-publishing isn't broken in that sense. It's just that for the crates under the libs directory, we don't actually want those to be autopublished weekly like the other crates (we want them to be properly versioned only, so no ra_ap_la_arena etc). That is if we bump the actual version of a crate there, we want CI to publish that version on merge and that's it. Jonas fixed that up in a PR but I haven't checked if that actually works now.

@pksunkara
Copy link
Contributor

I think the version numbers went bad because of the renaming the workflow to autopublish.

@lnicola
Copy link
Member

lnicola commented Mar 13, 2024

Should be working now?

@lnicola lnicola closed this as completed Mar 13, 2024
@lnicola lnicola reopened this Mar 13, 2024
@lnicola
Copy link
Member

lnicola commented Mar 13, 2024

Looks like this failed in https://github.com/rust-lang/rust-analyzer/actions/runs/8144079470/job/22257391219#step:5:48:

error: failed to publish to registry at https://crates.io/

Caused by:
  the remote server responded with an error (status 403 Forbidden): must be logged in to perform that action
error: unable to publish package stdx

@Veykril
Copy link
Member Author

Veykril commented Mar 13, 2024

Trying to publish stdx? 😕

@Veykril
Copy link
Member Author

Veykril commented Mar 13, 2024

Oh, it is because I added stdx as a dep to xtask which we aren't excluding like we do for /crates in the workflow via sed

bors added a commit that referenced this issue Mar 19, 2024
internal: Move grammar codegen into xtask

#14778, also threw in the one line fix for #13912
@lnicola lnicola closed this as completed Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infra CI and workflow issues C-feature Category: feature request
Projects
None yet
Development

No branches or pull requests

4 participants