-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I have 600 lexer-stage errors and VS Code/RA cannot keep up #3782
Comments
What's your environment? |
MacBook Pro running macOS 10.15.3 with 6-core 2.2 GHz i7 and 32 GB RAM, running stable Rust. |
Vscode, version of rust analyzer? |
Ah, sorry -- I have VS Code 1.43.2 and RA 0.2.108. |
(BTW, the lag introduced on pressing the Enter key is especially annoying in this kind of scenario.) |
Do you have enhanced typing enabled? You may want to disable that and see how it goes. A reproducible project would be great. |
This might be the related case reported in zulip: @djc do you observe the 100% single CPU core load when this happens? |
The code was somewhat similar to this (I've recreated this from what I had originally): https://github.com/djc/tokio-imap/blob/ra-sloooow/imap-proto/src/parser/rfc3501/mod.rs I was refactoring nom parsers from macro-style to function-style, starting from a replace of What is enhanced typing exactly? I can't find it in the settings. |
My mistake. They setting doesn't exist anymore.
…On Wed, Apr 1, 2020, 4:03 PM Dirkjan Ochtman ***@***.***> wrote:
The code was somewhat similar to this (I've recreated this from what I had
originally):
https://github.com/djc/tokio-imap/blob/ra-sloooow/imap-proto/src/parser/rfc3501/mod.rs
I was refactoring nom parsers from macro-style to function-style, starting
from a replace of !( to (. The do_parse!() macro in particular has some
funky syntax going on.) I'm on a different machine now with a 2,3 GHz
8-Core Intel Core i9, so the performance is much better (not getting 100%
CPU on any of this machine's cores), but I'm still seeing similar issues.
Would not be surprised if I had 100% CPU on the work laptop.
What is enhanced typing exactly? I can't find it in the settings.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3782 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBACRCFD3YAOU5LACPY7NLRKOMYRANCNFSM4LXKHFWQ>
.
|
Enhanced typing is now disabled by default and we limit the number of errors returned to the client. @djc are you still seeing this? (Marking |
I did some spot checking against the old branch and it does look like this is fixed. Thanks! |
It appears like RA tries to process every edit before re-analyzing, but then takes longer to re-analyze than I need to do the next edit. (Current first error: "Syntax Error: expected COMMA".)
The text was updated successfully, but these errors were encountered: