Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable backtrace on CI #3769

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Enable backtrace on CI #3769

merged 1 commit into from
Mar 30, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Mar 30, 2020

bors r+
🤖

@matklad matklad merged commit 846cbe7 into rust-lang:master Mar 30, 2020
@matklad matklad deleted the bt branch March 30, 2020 08:52
bjorn3
bjorn3 reviewed Mar 30, 2020
View reviewed changes
.github/workflows/ci.yaml
@@ -11,6 +11,7 @@ env:
CARGO_INCREMENTAL: 0
CARGO_NET_RETRY: 10
RUN_SLOW_TESTS: 1
RUST_BACKTRACE: short
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The short backtraces have been broken for years. Doesn't hurt to use this though.

lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Sep 25, 2024
@bors
Auto merge of rust-lang#3769 - primoly:miri-start, r=RalfJung
bc6ab6a 
Add `miri_start` support

This PR uses a function with the exported symbol `miri_start` as a drop-in alternative to `#[start]`. So the signature stays the same as suggested in [this comment](rust-lang/miri#3498 (comment)). <del>I’ve also removed Miri’s restriction  to only work on bin crates as I don’t think this is necessary anymore.</del>

Closes rust-lang#3758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matklad @bjorn3