Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider #5656 after Range::is_empty stabilization #5956

Closed
scottmcm opened this issue Aug 24, 2020 · 5 comments · Fixed by #5961
Closed

Reconsider #5656 after Range::is_empty stabilization #5956

scottmcm opened this issue Aug 24, 2020 · 5 comments · Fixed by #5961

Comments

@scottmcm
Copy link
Member

I don't want to make clippy logic changes as part of a stabilization PR, so I'm filing this to remind myself to follow up with a better clippy change.

Stabilization PR: rust-lang/rust#75132
Clippy change to potentially revert: #5656
@ebroto
Copy link
Member

ebroto commented Aug 24, 2020 •
edited
Loading

I can take care of fixing this so it lands with 1.47.

Hmm wait, we will not sync clippy until after 1.46 is released, so it will have to be for 1.48.

@flip1995
Copy link
Member

The rust PR may not even hit beta. And if it does we can still make those changes and backport them.

@scottmcm
Copy link
Member Author

scottmcm commented Aug 25, 2020 •
edited
Loading

Ok, the stabilization did hit beta.

I've not changed clippy before; what's the best update to make here? Maybe revert #5656, but then put back the Range/RangeInclusive-specific tests?

PR Up.

@scottmcm scottmcm mentioned this issue Aug 25, 2020
Merged
@bors bors closed this as completed in e191151 Aug 25, 2020
@flip1995
Copy link
Member

I will do the backport after the release on Thursday 👍

@flip1995
Copy link
Member

rust-lang/rust#76051

@flip1995 flip1995 mentioned this issue Aug 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable len_zero for ranges now that is_empty is stable on them scottmcm/rust-clippy
3 participants
@ebroto @flip1995 @scottmcm