Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Clippy backport for stabilization of range_is_empty feature #76051

Closed
wants to merge 3 commits into from
Closed

[beta] Clippy backport for stabilization of range_is_empty feature #76051

wants to merge 3 commits into from

Conversation

flip1995
Copy link
Member

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 29, 2020
@flip1995 flip1995 mentioned this pull request Aug 29, 2020
Closed
@Mark-Simulacrum
Copy link
Member

Hm, we don't usually backport changes to lints. Is there a reason you feel we should make this backport happen? As far as I can tell, this lint isn't for correctness or anything, so we could probably let it ride the trains?

@flip1995
Copy link
Member Author

I don't have a particular reason, why we should backport this. The stabilization PR author @scottmcm asked about it: rust-lang/rust-clippy#5956

It would get the stabilized behavior of the lint into the same release as the stabilization of the feature, which is nice to have, but not a must-have backport. So I would leave it up to you to decide if this should get backported or not.

@Mark-Simulacrum
Copy link
Member

Okay, I'm going to beta-nominate for T-compiler to take a look at, but I personally feel that while we could backport this. It has a relatively small diff, which is nice.

@Mark-Simulacrum Mark-Simulacrum added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 31, 2020
@scottmcm
Copy link
Member

scottmcm commented Sep 2, 2020

(Commenting because of the ping) I'm happy whether or not this backport goes in. I filed the clippy issue to make sure the lint was updated eventually, but I don't think there's any particular reason that this change to this lint needs to go in the same train as the stabilization. But this is also the first time I'd changed clippy, so I have no idea what the usual process is -- y'all should do what you think is best 🙂

@spastorino
Copy link
Member

discussed in T-compiler meeting, declined to backport.

@rustbot modify labels: -beta-nominated

@rustbot rustbot removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 3, 2020
@flip1995 flip1995 closed this Sep 3, 2020
@flip1995 flip1995 deleted the clippy-backport branch September 3, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@flip1995 @rust-highfive @Mark-Simulacrum @scottmcm @spastorino @nikomatsakis @rustbot