Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[significant_drop_tightening] Fix #11128 #11129

Merged
merged 2 commits into from
Jul 8, 2023
Merged

[significant_drop_tightening] Fix #11128 #11129

merged 2 commits into from
Jul 8, 2023

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Jul 8, 2023 •
edited
Loading

Fix #11128

changelog: [`significant_drop_tightening`]: Consider manual aliases of the `drop` function.

@rustbot
Copy link
Collaborator

rustbot commented Jul 8, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 8, 2023
@Manishearth
Copy link
Member

@bors r+

thanks!

@bors
Copy link
Contributor

bors commented Jul 8, 2023

📌 Commit 2be695b has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 8, 2023

⌛ Testing commit 2be695b with merge 8fcd476...

bors added a commit that referenced this pull request Jul 8, 2023
@bors
Auto merge of #11129 - c410-f3r:lock-1, r=Manishearth
8fcd476 
[significant_drop_tightening] Fix #11128

Fix #11128

```
changelog: [`significant_drop_tightening`]: Consider manual alias of the `drop` function.
```
@bors
Copy link
Contributor

bors commented Jul 8, 2023

💔 Test failed - checks-action_test

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 8, 2023

📌 Commit 6384221 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 8, 2023

⌛ Testing commit 6384221 with merge 6ae065f...

@bors
Copy link
Contributor

bors commented Jul 8, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 6ae065f to master...

@bors bors merged commit 6ae065f into rust-lang:master Jul 8, 2023
@c410-f3r c410-f3r mentioned this pull request Jul 9, 2023
Closed
@blyxyas blyxyas mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees

@Manishearth Manishearth

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[significant_drop_tightening] drop aliases are ignored.
4 participants
@c410-f3r @rustbot @Manishearth @bors