-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation to the span_lint_hir
functions
#12445
Conversation
r? @Manishearth rustbot has assigned @Manishearth. Use r? to explicitly pick a reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to see these functions getting some love!
I have a few suggestions, but either way, this is a really awesome change!
r? @xFrednet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope my comments are not too nit-picky :D
Changed the documentation a bit with (a lot of) inspiration taken from the suggestions
It's fine, especially for a PR like this. These functions are used everywhere, so imo having good documentation here is important. So feel free to point out things that you would phrase differently, even small details. |
Perfect, I like this version! This is a really nice improvement :D @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
As far as I could tell, these weren't documented anywhere, and since this is sometimes needed over
span_lint
for#[allow]
attrs to work, I thought I would add a little bit of documentation.When I started with clippy development, I also had no idea what these functions were for.
changelog: none