fix: map_entry FP on struct member
#14151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
r? clippy |
Centri3
reviewed
Feb 18, 2025
clippy_lints/src/entry.rs
Outdated
Comment on lines
565
to
579
| fn is_map_or_parent_used(cx: &LateContext<'_>, map: &Expr<'_>, expr: &Expr<'_>) -> bool { | ||
| SpanlessEq::new(cx).eq_expr(map, expr) | ||
| || matches!(map.kind, ExprKind::Field(inner, _) | ExprKind::Index(inner, _, _) if is_map_or_parent_used(cx, inner, expr)) | ||
| } | ||
|
|
There was a problem hiding this comment.
I believe for_each_expr would be nicer.
Note this usage of || is clever but hard to read at first.
Also, can you try to document this function a bit? My initial 2min look leaves me a bit confused on mostly the name. I'm not sure if it's misleading or I'm missing context not present in the diff.
I can reroll or look closer later but I believe just the refactoring I've suggested is what this needs.
profetia
force-pushed
the
issue13934
branch
3 times, most recently
from
8d082dd to
1d3d43c
Compare
Centri3
reviewed
Feb 19, 2025
clippy_lints/src/entry.rs
Outdated
| /// Check if the given expression is used for each sub-expression in the given map. | ||
| /// For example, in map `a.b.c.my_map`, The expression `a.b.c.my_map`, `a.b.c`, `a.b`, and `a` are | ||
| /// all checked. | ||
| fn is_each_expr_in_map_used<'tcx>(cx: &LateContext<'tcx>, map: &'tcx Expr<'tcx>, expr: &'tcx Expr<'tcx>) -> bool { |
There was a problem hiding this comment.
is_any_expr_in_map_used is closer to what it does, yes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13934
I modified the part for checking if the map is used so that it can check field and index exprs.
changelog: [
map_entry]: fix FP on struct member