`unnecessary_to_owned`: don't call `iter()` on a temporary object #14243

lapla-cogito · 2025-02-17T18:28:04Z

changelog: [unnecessary_to_owned]: don't call iter on a temporary object

rustbot · 2025-02-17T18:28:09Z

rustbot has assigned @Centri3.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

clippy_lints/src/methods/unnecessary_to_owned.rs

rustbot assigned Centri3 Feb 17, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 17, 2025

lapla-cogito force-pushed the issue_14242 branch from 95a5ce9 to d8286f5 Compare February 17, 2025 18:42

samueltardieu reviewed Feb 17, 2025

View reviewed changes

clippy_lints/src/methods/unnecessary_to_owned.rs Outdated Show resolved Hide resolved

lapla-cogito force-pushed the issue_14242 branch from d8286f5 to 9be2d63 Compare February 19, 2025 17:22

lapla-cogito requested a review from Centri3 February 19, 2025 17:26

lapla-cogito force-pushed the issue_14242 branch from 9be2d63 to 6651fac Compare February 19, 2025 19:40

Centri3 reviewed Feb 22, 2025

View reviewed changes

clippy_lints/src/methods/unnecessary_to_owned.rs Outdated Show resolved Hide resolved

lapla-cogito added 3 commits February 25, 2025 22:40

add is_expr_temporary_value helper function

f2c9d90

apply is_expr_temporary_value to Clippy source

ed39b5d

don't call iter() on a temporary object in unnecessary_to_owned

5a849d9

lapla-cogito force-pushed the issue_14242 branch from 6651fac to 5a849d9 Compare February 25, 2025 13:48

lapla-cogito requested a review from Centri3 February 25, 2025 13:50

Provide feedback