build: do not reinstall master toolchain if it is up-to-date #4713
Conversation
tesuji
force-pushed
the
no-reinstall-toolchain
branch
from
0515464 to
f9d2a1f
Compare
flip1995
added
the
S-waiting-on-review
|
When I run |
Yes, I can also reproduce this. About 5% of the time it will take 10+ seconds to get the result. On my slow 20Mbps connection this PR is still a significant speed up currently. Also considering that it isn't always that slow, I'd say it's fine to merge this? |
tesuji
force-pushed
the
no-reinstall-toolchain
branch
from
f9d2a1f to
e780756
Compare
|
Note that old commit used git : https://github.com/rust-lang/rust-clippy/blob/3fb497c8c860cb286ed59fa49bc1796086196697/setup-toolchain.sh. |
|
☔ The latest upstream changes (presumably #4650) made this pull request unmergeable. Please resolve the merge conflicts. |
tesuji
force-pushed
the
no-reinstall-toolchain
branch
3 times, most recently
from
608e2d0 to
6193b36
Compare
|
Ci passed |
|
@bors r+ thanks! |
|
📌 Commit 6193b36 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened |
|
@bors treeclose- |
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again. |
|
📌 Commit 6193b36 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened |
|
@bors treeclosed- |
build: do not reinstall master toolchain if it is up-to-date changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
changelog: none