Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LOG2_10 and LOG10_2 to approx_const lint #5193

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Add LOG2_10 and LOG10_2 to approx_const lint #5193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clippy_lints/src/approx_const.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ declare_clippy_lint! {
}

// Tuples are of the form (constant, name, min_digits)
const KNOWN_CONSTS: [(f64, &str, usize); 16] = [
const KNOWN_CONSTS: [(f64, &str, usize); 18] = [
(f64::E, "E", 4),
(f64::FRAC_1_PI, "FRAC_1_PI", 4),
(f64::FRAC_1_SQRT_2, "FRAC_1_SQRT_2", 5),
Expand All @@ -52,6 +52,8 @@ const KNOWN_CONSTS: [(f64, &str, usize); 16] = [
(f64::LN_2, "LN_2", 5),
(f64::LOG10_E, "LOG10_E", 5),
(f64::LOG2_E, "LOG2_E", 5),
(f64::LOG2_10, "LOG2_10", 5),
(f64::LOG10_2, "LOG10_2", 5),
(f64::PI, "PI", 3),
(f64::SQRT_2, "SQRT_2", 5),
];
Expand Down
6 changes: 6 additions & 0 deletions tests/ui/approx_const.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ fn main() {
let my_log2_e = 1.4426950408889634;
let no_log2_e = 1.442;

let log2_10 = 3.321928094887362;
let no_log2_10 = 3.321;

let log10_2 = 0.301029995663981;
let no_log10_2 = 0.301;

let my_pi = 3.1415;
let almost_pi = 3.14;
let no_pi = 3.15;
Expand Down
20 changes: 16 additions & 4 deletions tests/ui/approx_const.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,23 +96,35 @@ error: approximate value of `f{32, 64}::consts::LOG2_E` found. Consider using it
LL | let my_log2_e = 1.4426950408889634;
| ^^^^^^^^^^^^^^^^^^

error: approximate value of `f{32, 64}::consts::LOG2_10` found. Consider using it directly
--> $DIR/approx_const.rs:48:19
|
LL | let log2_10 = 3.321928094887362;
| ^^^^^^^^^^^^^^^^^

error: approximate value of `f{32, 64}::consts::LOG10_2` found. Consider using it directly
--> $DIR/approx_const.rs:51:19
|
LL | let log10_2 = 0.301029995663981;
| ^^^^^^^^^^^^^^^^^

error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly
--> $DIR/approx_const.rs:48:17
--> $DIR/approx_const.rs:54:17
|
LL | let my_pi = 3.1415;
| ^^^^^^

error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly
--> $DIR/approx_const.rs:49:21
--> $DIR/approx_const.rs:55:21
|
LL | let almost_pi = 3.14;
| ^^^^

error: approximate value of `f{32, 64}::consts::SQRT_2` found. Consider using it directly
--> $DIR/approx_const.rs:52:18
--> $DIR/approx_const.rs:58:18
|
LL | let my_sq2 = 1.4142;
| ^^^^^^

error: aborting due to 19 previous errors
error: aborting due to 21 previous errors